Revise last updated date and add access instructions#587
Merged
priyanshu6238 merged 4 commits intomainfrom Apr 2, 2026
Merged
Conversation
Updated last updated date and added section on Google Sheet access via Service Account.
Contributor
📝 WalkthroughWalkthroughUpdated the Google Sheets linking documentation: changed "Last Updated" to April 2026, replaced link-based "Anyone with the link" sharing guidance with service-account-based sharing (or optional link-based alternative), renumbered writable-setup steps, removed an outdated screenshot, and added a new "Google Sheet Access via Service Account" section with image. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🚀 Deployed on https://deploy-preview-587--glific-docs.netlify.app |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/4`. Product Features/03. Flows/2. Flow Actions/12. Link Google
Sheets.md:
- Around line 385-397: Make the Google Sheets access guidance consistently
recommend using the Google Service Account flow (the "Google Sheet Access via
Service Account" section) as the primary and preferred method, and change any
earlier instructions that instruct users to set "Anyone with the link"/"Anyone
can read" sharing to instead mark that link-sharing as discouraged/deprecated
and only for non-PII test data; update the earlier section that mentions "Anyone
with the link" to explicitly warn about data exposure, point readers to the
service-account sharing steps (referencing the "Google Sheet Access via Service
Account" heading), and remove or rephrase any step that instructs granting link
access as a normal configuration.
- Around line 387-397: Rewrite the paragraph into clear numbered steps and fix
typos: replace "To ensure sensitive beneficiary data (PII) is protected,avoid
linking Google Sheets..." with a full sentence and space after the comma; change
"will be access" to "will be accessed"; remove the stray "Link Sheet in Glific"
line and fold that action into the step list; produce 3–4 numbered steps that
instruct the user to open the Google Sheet, click Share and paste the service
account email (from the JSON key) with Viewer or Editor permission, and note
that the sheet will be accessed via the Glific service account respecting those
permissions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fb364868-539e-4553-b56d-585a4dddbf50
📒 Files selected for processing (1)
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
Show resolved
Hide resolved
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
Show resolved
Hide resolved
Contributor
can you also change the 5 line |
priyanshu6238
approved these changes
Mar 31, 2026
Contributor
priyanshu6238
left a comment
There was a problem hiding this comment.
LGTM. Apart from that one minor comment, please merge it once it’s resolved.
priyanshu6238
requested changes
Mar 31, 2026
Updated instructions for linking Google Sheets to clarify permissions and steps for sharing with service accounts.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md (1)
384-395:⚠️ Potential issue | 🟡 MinorPlease normalize this new section into clean numbered steps and fix grammar.
This block still has the same wording/format issues (
protected,avoid,1.Open,will be access, and standalone “Link Sheet in Glific”). It should be rewritten for clarity and consistency.✍️ Suggested rewrite
### Google Sheet Access via Service Account -To ensure sensitive beneficiary data (PII) is protected,avoid linking Google Sheets in Anyone can read or Anyone can read/write modes. +To protect sensitive beneficiary data (PII), avoid linking Google Sheets using **Anyone with the link** access (read or read/write). Instead, configure access via the Google Service Account linked to your Glific instance. -1.Open the Google Sheet you want to link. - -2. Click Share → Paste the service account email (from the JSON key) and set the permission to either Viewer (read-only) or Editor (read/write). -3. Link Sheet in Glific -4. Now the sheet will be access via the service account, respecting the permissions set. +1. Open the Google Sheet you want to link. +2. Click **Share**, paste the service account email (from the JSON key), and grant: + - **Viewer** for read-only access, or + - **Editor** for read/write access. +3. Link the sheet in Glific. +4. The sheet will now be accessed via the service account, respecting the granted permissions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/4`. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md around lines 384 - 395, Rewrite the "Google Sheet Access via Service Account" section into clean numbered steps with correct grammar and punctuation: merge the opening sentence to "To ensure sensitive beneficiary data (PII) is protected, avoid linking Google Sheets in 'Anyone can read' or 'Anyone can read/write' modes; instead, grant access to the Google Service Account associated with your Glific instance." Then produce four clear steps: 1) Open the Google Sheet, 2) Click Share and paste the service account email from the JSON key, setting Viewer or Editor as needed, 3) Link the sheet in Glific, and 4) Confirm the sheet is accessed via the service account which will respect the set permissions. Replace broken fragments like "protected,avoid", "1.Open", "will be access", and the standalone "Link Sheet in Glific" with the corrected phrasing above.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/4`. Product Features/03. Flows/2. Flow Actions/12. Link Google
Sheets.md:
- Line 45: Update the step that reads "Open the Google sheet and click on share
button on the right hand side to update the sheet permission with the service
account email (from the JSON key) and set the permission to either Viewer
(read-only) or Editor (read/write)." to use "right-hand side" and streamline
wording; e.g., "Open the Google sheet, click the Share button on the right-hand
side, add the service account email from the JSON key, and set its role to
Viewer (read-only) or Editor (read/write)." Target the sentence in step 5.
---
Duplicate comments:
In `@docs/4`. Product Features/03. Flows/2. Flow Actions/12. Link Google
Sheets.md:
- Around line 384-395: Rewrite the "Google Sheet Access via Service Account"
section into clean numbered steps with correct grammar and punctuation: merge
the opening sentence to "To ensure sensitive beneficiary data (PII) is
protected, avoid linking Google Sheets in 'Anyone can read' or 'Anyone can
read/write' modes; instead, grant access to the Google Service Account
associated with your Glific instance." Then produce four clear steps: 1) Open
the Google Sheet, 2) Click Share and paste the service account email from the
JSON key, setting Viewer or Editor as needed, 3) Link the sheet in Glific, and
4) Confirm the sheet is accessed via the service account which will respect the
set permissions. Replace broken fragments like "protected,avoid", "1.Open",
"will be access", and the standalone "Link Sheet in Glific" with the corrected
phrasing above.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 11a0dc52-c22a-4cba-adf6-0e1678ed30b8
📒 Files selected for processing (1)
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
Outdated
Show resolved
Hide resolved
priyanshu6238
requested changes
Apr 1, 2026
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
Outdated
Show resolved
Hide resolved
Updated instructions for sharing Google Sheets with service account email and added an alternative permission option.
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (2)
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md (2)
388-397:⚠️ Potential issue | 🟡 MinorFix grammar and step formatting in the service-account section.
There are readability regressions: “protected,avoid”, “1.Open”, “will be access”, and an ungrammatical step title.
✍️ Suggested rewrite
-To ensure sensitive beneficiary data (PII) is protected,avoid linking Google Sheets in Anyone can read or Anyone can read/write modes. +To protect sensitive beneficiary data (PII), avoid linking Google Sheets using “Anyone can read” or “Anyone can read/write” modes. @@ -1.Open the Google Sheet you want to link. +1. Open the Google Sheet you want to link. @@ -3. Link Sheet in Glific -4. Now the sheet will be access via the service account, respecting the permissions set. +3. Link the sheet in Glific. +4. The sheet will now be accessed via the service account, respecting the permissions set.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/4`. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md around lines 388 - 397, Fix grammar and formatting in the service-account steps: add a space in “protected,avoid” → “protected, avoid”; change numbered step punctuation “1.Open” → “1. Open”; correct verb tense “will be access” → “will be accessed”; make step titles consistent and grammatical (e.g., “Share the sheet with the service account” for the Share step, and “Link sheet in Glific” → “Link the sheet in Glific.”); ensure each step is a separate line with terminal punctuation and consistent capitalization.
47-47:⚠️ Potential issue | 🟠 MajorConflicting access guidance still allows insecure sheet exposure.
Line 47 reintroduces link-public sharing while Lines 388-390 instruct avoiding that mode for PII. Keep service-account sharing as the default path, and clearly mark link-sharing as deprecated/non-PII-only to avoid accidental overexposure.
✍️ Suggested doc fix
-Alternatively, if you prefer not to add the service account email, you can change the sheet persmission to “Anyone with the link can view.” +⚠️ Avoid “Anyone with the link” for production or PII data. +Use service-account sharing as the recommended setup. +If you must use link-sharing, restrict it to non-sensitive test data only.Also applies to: 386-390
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/4`. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md at line 47, The doc currently contradicts itself by suggesting “Anyone with the link can view” as an alternative; change the guidance in the "Link Google Sheets" section to make service-account sharing the default and remove or reword the link-public recommendation to be explicitly deprecated and only for non-PII/test data. Update the sentence that currently reads “Anyone with the link can view” to instead warn that link-sharing is insecure, label it as deprecated/non-PII-only, and add a cross-reference to the service-account setup steps; apply the same edit to the duplicate guidance around the later lines that currently discuss link-sharing (the block that references avoiding link-public for PII).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@docs/4`. Product Features/03. Flows/2. Flow Actions/12. Link Google
Sheets.md:
- Around line 388-397: Fix grammar and formatting in the service-account steps:
add a space in “protected,avoid” → “protected, avoid”; change numbered step
punctuation “1.Open” → “1. Open”; correct verb tense “will be access” → “will be
accessed”; make step titles consistent and grammatical (e.g., “Share the sheet
with the service account” for the Share step, and “Link sheet in Glific” → “Link
the sheet in Glific.”); ensure each step is a separate line with terminal
punctuation and consistent capitalization.
- Line 47: The doc currently contradicts itself by suggesting “Anyone with the
link can view” as an alternative; change the guidance in the "Link Google
Sheets" section to make service-account sharing the default and remove or reword
the link-public recommendation to be explicitly deprecated and only for
non-PII/test data. Update the sentence that currently reads “Anyone with the
link can view” to instead warn that link-sharing is insecure, label it as
deprecated/non-PII-only, and add a cross-reference to the service-account setup
steps; apply the same edit to the duplicate guidance around the later lines that
currently discuss link-sharing (the block that references avoiding link-public
for PII).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6ccfdfa1-1d1b-436e-b73b-903550012322
📒 Files selected for processing (1)
docs/4. Product Features/03. Flows/2. Flow Actions/12. Link Google Sheets.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated last updated date and added section on Google Sheet access via Service Account.
Summary by CodeRabbit